Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][E2E] Use run expansions in kernel compiler tests #17174

Merged
merged 2 commits into from
Feb 27, 2025
Merged

[SYCL][E2E] Use run expansions in kernel compiler tests #17174

merged 2 commits into from
Feb 27, 2025

Conversation

ayylol
Copy link
Contributor

@ayylol ayylol commented Feb 25, 2025

No description provided.

@ayylol ayylol requested a review from a team as a code owner February 25, 2025 17:30
@ayylol ayylol requested a review from uditagarwal97 February 25, 2025 17:30
@ayylol
Copy link
Contributor Author

ayylol commented Feb 26, 2025

@intel/llvm-gatekeepers this is ready to merge

Failure in arc is #17176

Failed Tests (1):
SYCL :: ESIMD/matrix_transpose_glb.cpp

Testing Time: 199.19s

Total Discovered Tests: 2263
Unsupported : 529 (23.38%)
Passed : 1729 (76.40%)
Expectedly Failed: 4 (0.18%)
Failed : 1 (0.04%)

Failure in nvidia is #17026

Failed Tests (1):
SYCL :: HostInteropTask/interop-task-cuda-buffer-migrate.cpp

Testing Time: 186.44s

Total Discovered Tests: 2263
Unsupported : 1176 (51.97%)
Passed : 1065 (47.06%)
Expectedly Failed: 21 (0.93%)
Failed : 1 (0.04%)

aelovikov-intel
aelovikov-intel reviewed Feb 26, 2025
View reviewed changes
sycl/test-e2e/KernelCompiler/kernel_compiler_opencl.cpp Outdated
// RUN: %{cache_vars} %t.out 2>&1 | FileCheck %s --check-prefixes=CHECK-WRITTEN-TO-CACHE
// RUN: %{cache_vars} %t.out 2>&1 | FileCheck %s --check-prefixes=CHECK-READ-FROM-CACHE
// RUN: %{run-aux} rm -rf %t/cache_dir
// RUN: %{run} %{cache_vars} %t.out 2>&1 | FileCheck %s --check-prefixes=CHECK-WRITTEN-TO-CACHE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think %{run} should come after env right before %t.out. run_launcher might be an executable and all the env must be set before it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, moved.

aelovikov-intel
aelovikov-intel requested changes Feb 26, 2025
View reviewed changes
Copy link
Contributor

@aelovikov-intel aelovikov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see inline comment.

@martygrant martygrant merged commit 95ee1e3 into intel:sycl Feb 27, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uditagarwal97 uditagarwal97 uditagarwal97 approved these changes

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ayylol @uditagarwal97 @aelovikov-intel @martygrant