Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Recognize allow_content_tools and support force_integer_mv #1779

Open
rosetta-jpn opened this issue Mar 12, 2024 · 7 comments
Open
Assignees
Labels
AV1 AV1 Encode video encode related Feature Request Request a feature or enhancement

Comments

@rosetta-jpn
Copy link

What Feature?

Libva patch to configure allow_content_tools and force_integer_mv is merged.
intel/libva#795

If allow_screen_content_tools is set to true, the decoder reads palette mode info in intra_frame_mode_info() and intra_block_mode_info().
If palette mode is not enabled, then the encoder needs to fill has_palette_y and has_platte_uv to false.
So the driver need to recognize allow_content_tools (and palette mode) to produce a valid stream.

In addition, I would also like to ask adding force_integer_mv support to media-driver.

Thanks in advance.

What's the usage scenario would be benifited?

Video Conference, Content Creation

What impacted?

No response

Do you want to contribute a patch to develop this feature?

None

@rosetta-jpn rosetta-jpn added the Feature Request Request a feature or enhancement label Mar 12, 2024
@rosetta-jpn
Copy link
Author

@XinfengZhang Do you have any timeline for this?

@XinfengZhang
Copy link
Contributor

@rosetta-jpn
Copy link
Author

@XinfengZhang I tried on MeteoLake.

change the value to 0xc0a080 to have a try.

This doesn't make a difference on produced bitstream.

maybe also need add params.forceIntegerMv = 1

This makes the produced bitstream invalid (failed in decoding).

@XinfengZhang
Copy link
Contributor

hi hiro, could you help dump the encoding command buffer and share it.
BKM https://github.com/intel/media-driver/wiki/Decode-and-Encode-Debug-Tool-and-surface-dump

@rosetta-jpn
Copy link
Author

Nothing is output. I guess I don't build my driver in neither debug nor release-internal.
Could you tell me how to build the debug version driver?

@zlma7001
Copy link
Contributor

Hiro, we have verified PR #1794, and it hard code to force use integer MV if you would like to have a try, and I will paste the data for av1 vaapi encoder later.

@XinfengZhang XinfengZhang added Encode video encode related AV1 AV1 labels Apr 23, 2024
@intel-mediadev
Copy link
Contributor

Auto Created VSMGWL-73182 for further analysis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AV1 AV1 Encode video encode related Feature Request Request a feature or enhancement
Projects
None yet
Development

No branches or pull requests

4 participants