-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Recognize allow_content_tools and support force_integer_mv #1779
Comments
@XinfengZhang Do you have any timeline for this? |
hi @rosetta-jpn , you could do some quick evaluation with hard code to enable integer MV to be safe, maybe also need add params.forceIntegerMv = 1; in https://github.com/intel/media-driver/blob/master/media_softlet/agnostic/common/codec/hal/enc/av1/features/encode_av1_basic_feature.cpp#L880 |
@XinfengZhang I tried on MeteoLake.
This doesn't make a difference on produced bitstream.
This makes the produced bitstream invalid (failed in decoding). |
hi hiro, could you help dump the encoding command buffer and share it. |
Nothing is output. I guess I don't build my driver in neither debug nor release-internal. |
Hiro, we have verified PR #1794, and it hard code to force use integer MV if you would like to have a try, and I will paste the data for av1 vaapi encoder later. |
Auto Created VSMGWL-73182 for further analysis. |
What Feature?
Libva patch to configure allow_content_tools and force_integer_mv is merged.
intel/libva#795
If allow_screen_content_tools is set to true, the decoder reads palette mode info in intra_frame_mode_info() and intra_block_mode_info().
If palette mode is not enabled, then the encoder needs to fill has_palette_y and has_platte_uv to false.
So the driver need to recognize allow_content_tools (and palette mode) to produce a valid stream.
In addition, I would also like to ask adding force_integer_mv support to media-driver.
Thanks in advance.
What's the usage scenario would be benifited?
Video Conference, Content Creation
What impacted?
No response
Do you want to contribute a patch to develop this feature?
None
The text was updated successfully, but these errors were encountered: