SPR metric: Incorrect ParentCategory for Serializing_Operation?

[laksono]

I think Serializing_Operation metric shouldn't have Ports_Utilized_0 as the parent:

https://github.com/intel/perfmon/blob/b2fa7da33a63ecbfe981295f16afbc930aa77422/SPR/metrics/sapphirerapids_metrics.json#L7445C7-L7448C18

  "MetricName": "Serializing_Operation",
  "LegacyName": "metric_TMA_....Serializing_Operation(%)",
  "ParentCategory": "Ports_Utilized_0",
  "Level": 3,

Here, Serializing_Operation is level 3, but the parent is level 4:

https://github.com/intel/perfmon/blob/b2fa7da33a63ecbfe981295f16afbc930aa77422/SPR/metrics/sapphirerapids_metrics.json#L7837C1-L7840C18

  "MetricName": "Ports_Utilized_0",
  "LegacyName": "metric_TMA_......Ports_Utilized_0(%)",
  "ParentCategory": "Ports_Utilization",
  "Level": 4,

According to the Excel file, the parent of Serializing_Operation should be Core_bound metric.

[edwarddavidbaker]

Thanks for opening an issue. TMA metrics were removed from metrics/*_metrics.json files in favor of the Excel file #293 . Do TMA Excel/CSV files support your use case?

---

You're correct Serializing_Operation is a child of Core_Bound. Screenshot from TMA 5.02.

[laksono]

Thanks for opening an issue. TMA metrics were removed from metrics/*_metrics.json files in favor of the Excel file #293 . Do TMA Excel/CSV files support your use case?

Yes, the Excel file works just fine. Thanks.

Btw it is unfortunate that metrics/*_metrics.json files are not maintained anymore since they allow 3rd party tools to extract information easily.

[edwarddavidbaker]

Thanks for the feedback @laksono .

[1perrytaylor]

To clarify, the metric files maintained under the /metrics directories will continue to be maintained for both TMA and non-TMA metrics. These metrics are presented in what we call our "standard JSON" format which is not compatible with Linux perf. The Linux perf conversion under the /metrics/perf directories will no longer contain the TMA metrics but will continue to have the non-TMA metrics and will continue to be maintained. This decision was made to better enable the Linux perf community who wanted to have more control over the exact format of the TMA metrics.

[edwarddavidbaker]

Thanks @1perrytaylor . Sorry about the error in my initial message! Pull request #293 modified metrics/perf/*.json .