Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FixedPoint should be a LogicStructure #184

Open
mkorbel1 opened this issue Mar 6, 2025 · 0 comments
Open

FixedPoint should be a LogicStructure #184

mkorbel1 opened this issue Mar 6, 2025 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@mkorbel1
Copy link
Contributor

mkorbel1 commented Mar 6, 2025

Motivation

The components of a FixedPoint should be independently accessible (sign, m, and n). A good way to do this is by making it a LogicStructure, like FloatingPoint is.

Also, we should probably change variable names m and n so that it is clear they represent the widths, so that m and n can be left to represent the components.

Desired solution

  • Convert FixedPoint into a LogicStructure
  • Make existing m and n into mWidth and nWidth.
  • Make m and n and sign now point to elements of the structure

Alternatives considered

No response

Additional details

No response

@mkorbel1 mkorbel1 added enhancement New feature or request help wanted Extra attention is needed labels Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant