Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message of Signal changed its value after ... #569

Open
awmoore-intel opened this issue Feb 25, 2025 · 5 comments
Open

Improve error message of Signal changed its value after ... #569

awmoore-intel opened this issue Feb 25, 2025 · 5 comments
Labels
enhancement New feature or request

Comments

@awmoore-intel
Copy link

Motivation

I am getting this error message but have no idea what signal has the issue.

Signal changed its value after being used within one `Combinational` execution. This can 
lead to a mismatch between simulation and synthesis. You may be able to use 
`Combinational.ssa` to correct your design with minimal refactoring.

Desired solution

Indicate what signal/object has the problem

Alternatives considered

No response

Additional details

This was seen when using signals inside a FiniteStateMachine.

@awmoore-intel awmoore-intel added the enhancement New feature or request label Feb 25, 2025
@mkorbel1
Copy link
Contributor

Thanks for raising this. If I recall, there's a potential performance implication for the "obvious" refactor here to get more context during simulation, but I agree it's important for debug to reveal more information, this is worth fixing.

@mkorbel1
Copy link
Contributor

Meanwhile, this post can provide some insight potentially to help debug:
https://intel.github.io/rohd-website/blog/combinational-ssa/

@awmoore-intel
Copy link
Author

Meanwhile, this post can provide some insight potentially to help debug: https://intel.github.io/rohd-website/blog/combinational-ssa/

Nice post! I tried to use Combinational.ssa in FiniteStatemachine but it required a Conditional, so didn't work for me.

@mkorbel1
Copy link
Contributor

Nice post!

Thanks!

I tried to use Combinational.ssa in FiniteStatemachine but it required a Conditional, so didn't work for me.

Yes, I think this would require a new flavor of FSM, maybe something like State.ssa, to use that feature within there.

@mkorbel1
Copy link
Contributor

Filed #571

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants