Add env param KV_CACHE_LOCATION to control kv cache memory numanode location #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocation Usage: before you run instance export KV_CACHE_LOCATION=#memory_numa_node_id_you_want_to_use_for_kv_cache by defaults, kv_cache location is the same as other parts of instance.
|
@a3213105 we need to put the environment reading to a unified place, please put it to environment.h |
DONE |
pujiang2018
reviewed
Jul 3, 2024
src/utils/environment.h
Outdated
| @@ -71,6 +71,9 @@ class Env { | |||
| // get Primitive Cache M | |||
| int getPrimitiveCacheM() { return primitiveCacheM; } | |||
|
|
|||
| // get KV Cache Location | |||
| int getKVCacheLocation() { return primitiveCacheM; } | |||
There was a problem hiding this comment.
should be kvCacheLocation? and initKVCacheLocation is never called?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage:
before you run instance
export KV_CACHE_LOCATION=#memory_numa_node_id_you_want_to_use_for_kv_cache
by defaults, kv_cache location is the same as other parts of instance.