Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable Google sign-in #10044

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Re-enable Google sign-in #10044

merged 2 commits into from
Nov 19, 2024
+2 −21

Conversation

jimchamp
Copy link
Collaborator

@jimchamp jimchamp commented Nov 18, 2024 •
edited
Loading

Closes #10042

Removes error message and re-enables Google sign-in on login and new account registration pages.

Technical

Testing

While logged out:

  1. Attempt to login with your Google account.

Screenshot

Stakeholders

@github-actions github-actions bot added the Priority: 1 Do this week, receiving emails, time sensitive, . [managed] label Nov 18, 2024
@jimchamp jimchamp added On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing and removed Needs: Testing labels Nov 18, 2024
@jimchamp
Copy link
Collaborator Author

I've tested this by logging into testing, and the redirect to "My Books" seems a bit slow.

@mekarpeles
Copy link
Member

LGTM, tested on testing.

@mekarpeles mekarpeles merged commit 347be6d into internetarchive:master Nov 19, 2024
3 checks passed
@mekarpeles mekarpeles self-assigned this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mekarpeles mekarpeles

Labels
On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing Priority: 1 Do this week, receiving emails, time sensitive, . [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-enable google sign in
2 participants
@jimchamp @mekarpeles