Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload covers via copy/paste #9993

Open
RayBB opened this issue Nov 5, 2024 · 2 comments
Open

Upload covers via copy/paste #9993

RayBB opened this issue Nov 5, 2024 · 2 comments
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Response Issues which require feedback from lead Priority: 3 Issues that we can consider at our leisure. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@RayBB
Copy link
Collaborator

RayBB commented Nov 5, 2024

Proposal

We would like to be able to upload covers via copy/paste.
Also drag/drop would be nice.
We can no longer support uploading via remote URLs for security purposes.

Justification

The problem is now people have to download and then upload covers which creates friction.

This would make things easier to upload.

I know our current upload system is in an old iframe and a little hard to develop with (in my opinion)

Breakdown

Requirements Checklist

  • [ ]

Related files

Stakeholders


Instructions for Contributors

Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.

@RayBB RayBB added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Nov 5, 2024
@Freso
Copy link
Contributor

Freso commented Nov 5, 2024

FWIW, MusicBrainz/Cover Art Archive (another IA project) has a long-standing ticket for URL uploading: https://tickets.metabrainz.org/browse/MBS-4641

And there’s a community developed userscript to achieve this functionality: https://github.com/ROpdebee/mb-userscripts/tree/main?tab=readme-ov-file#mb-enhanced-cover-art-uploads (Ray asked me elsewhere to show a demonstration of the userscript in action, but due to the attack(s) on IA, cover art uploading and editing is currently disabled on MB.)

@github-actions github-actions bot added the Needs: Response Issues which require feedback from lead label Nov 6, 2024
@cdrini cdrini added Priority: 3 Issues that we can consider at our leisure. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Needs: Lead labels Nov 11, 2024
@mekarpeles
Copy link
Member

See: https://www.smashingmagazine.com/2018/01/drag-drop-file-uploader-vanilla-js/ for an example of how this can be done with vanilla js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Response Issues which require feedback from lead Priority: 3 Issues that we can consider at our leisure. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
Development

No branches or pull requests

4 participants