Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github documentation contradicts code comments #117

Open
sleepylucy opened this issue Apr 30, 2019 · 3 comments
Open

Github documentation contradicts code comments #117

sleepylucy opened this issue Apr 30, 2019 · 3 comments
Assignees

Comments

@sleepylucy
Copy link

sleepylucy commented Apr 30, 2019

I was checking out the documentation for subscribeToLocationUpdates, and I noticed there's a difference between the Readme.md and the comment above the function
The Readme.md says:

If an error occurs, the block will execute with a status other than INTULocationStatusSuccess, and the subscription will be kept alive.

Meanwhile the comment above subscribeToSignificantLocationChangesWithBlock reads:

If an error occurs, the block will execute with a status other than INTULocationStatusSuccess, and the subscription will be canceled automatically.

Which one is it now?

@lwdupont lwdupont self-assigned this Apr 30, 2019
@lwdupont
Copy link
Contributor

Hmm.. good question. I will look today and let you know.

@sleepylucy
Copy link
Author

Thanks!

@lwdupont
Copy link
Contributor

lwdupont commented May 1, 2019

So, in looking at the documentation vs the code, I believe the read me is correct, and the header comment is wrong.

Calling subscribeToSignificantLocationChangesWithBlock subscribes, meaning in the code it keeps around the block until the caller specifically cancels it.

I'll adjust the comment in the code tomorrow and mention it here (and tag you).

Thanks for bringing this up @sleepylucy 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants