-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adopt Microsoft.Extensions.* #286
Comments
https://learn.microsoft.com/en-us/dotnet/core/extensions/logging has a good overview of Microsoft.Extensions.Logging, including the intent of each log level. Aside from Serilog, a pain point with the current logging is it's almost all at the same level. Would help to promote some things to warnings, have basic request URL logged as info, and make sure everything with sensitive data (auth codes/headers, request/response bodies) uses I think the right approach is to give |
Haven't looked at OAuth yet, but for the main package it seems like we'd want something like
Any other thoughts from your experiments, @MatthewSteeples? |
@dahlbyk speaks the truth! I would love to see some of this integrated. |
Pullling out of #221 for discussion:
Microsoft.Extensions.Logging
should replaceIntuit.Ipp.Diagnostics.ILogger
JsonFileConfigurationProvider
usesMicrosoft.Extensions.Configuration
, but doesn't take advantage of its strongly-typed patterns.IConfigurationRoot
gets built; many apps (especially all ASP.NET Core) will have existing configServiceProvider
withMicrosoft.Extensions.DependencyInjection
could have access to everything you need to access current configuration, resolve anILoggerProvider
, etcAll things being equal, I would probably target version 2.1.x for these dependencies due to support on .NET Framework.
The text was updated successfully, but these errors were encountered: