Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements for error pages #184

Open
kpsherva opened this issue Sep 7, 2020 · 1 comment
Open

improvements for error pages #184

kpsherva opened this issue Sep 7, 2020 · 1 comment
Labels
enhancement New feature or request nice-to-have

Comments

@kpsherva
Copy link
Contributor

kpsherva commented Sep 7, 2020

Here are my latest thoughts:

  • When a 500 error occurs on any endpoint, we would intercept it on base.js:23, and trigger a (new) action
  • A component placed at the level of BackOffice.js:13 would have a conditional display of the main content depending on the value of this action. If everything goes well, the children are displayed - nothing changes. In case of an error it would replace the pane content by the 500 error page. Similar pattern on the frontsite
  • That way we ensure that if something is wrong the interactive part of the interface disappears. But most importantly we don't need to implement fine grained logic for each page as it would be handled globally
  • This could be extended to HTTP errors other than 500; I can think of 403, 404 and 429

It would essentially look like the following with the corresponding error page displayed (again, same for the frontsite):

image

Originally posted by @FlorianCassayre in #176 (comment)

@kpsherva kpsherva added enhancement New feature or request nice-to-have labels Sep 7, 2020
@FlorianCassayre
Copy link
Member

Also check that inveniosoftware/invenio-app-ils#213 is implemented (backend).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request nice-to-have
Projects
None yet
Development

No branches or pull requests

2 participants