fix(modal): dismiss keyboard on drag card modal #30020
Open
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This is a breaking change for my use case, where users desire the keyboard to remain present. A better solution would be adding onDragStart event to modal so developers can customize behavior - see: #23955 (comment) |
|
@aeharding actually, this is exactly the same behavior as the sheet modal; which closes the keyboard on drag. Can you show me an example of your use case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30019
What is the current behavior?
Dragging a card modal on iOS while the keyboard is open does not close the keyboard.
What is the new behavior?
Dragging a card modal closes the keyboard.
Does this introduce a breaking change?
Other information
ScreenRecording_11-14-2024.13-51-10_1.mov
Simulator.Screen.Recording.-.iPhone.16.-.2024-11-14.at.14.54.03.mp4