Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Project Reloads when adding files to wildcard patterns #1155

Open
TheAngryByrd opened this issue Sep 1, 2023 · 1 comment
Open

Handle Project Reloads when adding files to wildcard patterns #1155

TheAngryByrd opened this issue Sep 1, 2023 · 1 comment

Comments

@TheAngryByrd
Copy link
Member

TheAngryByrd commented Sep 1, 2023

We should add logic to handle Wildcarded files in fsproj files such as:

<Compile Include="CodeFixes/*.fsi" />
<Compile Include="CodeFixes/*.fs" />

In Adaptive, the additional dependencies is where it makes sense to watch for these files. We probably only want to do it upon Add or Delete but not modify.

Current workarounds:

  • Option 1: Reload Window (not ideal)
  • Option 2:
    • Save the fsproj file to mark it as updated
    • go to a file that it does know about (something that isn't wildcarded for example) and get it typechecked to force it to reload that project
@TheAngryByrd
Copy link
Member Author

Some initial investigation:

MsBuild expands out wildcarded Compile nodes on the parsing step. I could use an XPath to get these nodes but it won't for things that have variables like <Compile Include="$(RootPath)/Codefixes/*.fs" /> I'm not sure how to get MsBuild to return some partially applied path without expanding the wildcard and replacing variables without doing a lot of manual work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant