Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduction of non compliant java field names #57

Open
tdltdl opened this issue Feb 22, 2025 · 1 comment
Open

Introduction of non compliant java field names #57

tdltdl opened this issue Feb 22, 2025 · 1 comment

Comments

@tdltdl
Copy link

tdltdl commented Feb 22, 2025

Recently a field is_anycast has been introduced. This is not in line with Java naming convention.
The field should be called boolean anycast and the getter should be boolean isAnycast()

Will not merge those changes with the ongoing PRs.

@tdltdl
Copy link
Author

tdltdl commented Feb 22, 2025

You probably want to use
@SerializedName("is_anycast")
private final boolean anycast;

and, to be backward compatible add a method boolean isAnycast() (while marking the getAnycast as deprecated and remove it for next major version) and apply the same for all other boolean fields that have a getXxx()
And I would recommend to also use PR for your own changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant