Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

figure formatters not in this package #7

Open
minrk opened this issue Sep 29, 2021 · 3 comments
Open

figure formatters not in this package #7

minrk opened this issue Sep 29, 2021 · 3 comments

Comments

@minrk
Copy link
Member

minrk commented Sep 29, 2021

This package doesn't contain the figure formatters it uses, which are still all defined in IPython.core.pylabtools. Should they be here so that upgrading the matplotlib-inline package upgrades the inline-figure formatters?

@SylvainCorlay
Copy link
Member

Good catch, I agree they should definitely be moved here.

@fperez
Copy link
Member

fperez commented Aug 13, 2022

Should we try to do this before cutting a release? I can give it a try next week, though if someone has time to beat me to it, I'd appreciate it...

This package is very stable, so cutting a release that fixes these little nags would be nice (with that rcParams fix being a not-so little one that is really motivating me to get it done).

@fperez
Copy link
Member

fperez commented Aug 17, 2022

I made a release today (0.1.5) b/c I didn't want to linger on it as I might not have time later. But I'm happy to revisit this to do a bit of cleanup and push a 0.1.6 later... @minrk do you have any cycles to do this? If not I can give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants