Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Understand scale variation changes via correctionlib implementation #131

Closed
alexander-held opened this issue May 2, 2023 · 3 comments
Closed
Labels
bug Something isn't working implementation concerns analysis implementation

Comments

@alexander-held
Copy link
Member

#119 changed the pt_scale_up variations, in particular the following changes:

sum(all_histograms[:, "4j2b", "ttbar", "pt_scale_up"].values())

Prior to this PR, the propagation of the pT changes on the observable itself was not taken into account, so the bin-by-bin distribution in this region is expected to differ regardless before and after the PR. It is currently unclear though why also the total event count would change in this region.

The 4j1b region does not seem to be affected by this.

cc @Andrew42

@alexander-held alexander-held added implementation concerns analysis implementation bug Something isn't working labels May 2, 2023
@ekauffma
Copy link
Collaborator

As mentioned above, originally, pT variations were not propagated through when calculating the observable in region "4j2b". This is fixed with the correctionlib implementation.

Thus different events are cut off by the histogram binning. sum(all_histograms[:, "4j2b", "ttbar", "pt_scale_up"].values()) does not include overflow and underflow events, hence the difference. This problem also affected the "pt_res_up" variation, although the discrepancy was masked by the fact that the values differ randomly with each run.

Changing the histogram binning to include all events which were cut off reveals that the total event count remains the same.

@alexander-held
Copy link
Member Author

Thanks a lot for tracking this down @ekauffma!

@alexander-held alexander-held mentioned this issue Jun 22, 2023
4 tasks
@alexander-held
Copy link
Member Author

A backport for v1 is done via #163.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working implementation concerns analysis implementation
Projects
None yet
Development

No branches or pull requests

2 participants