Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test hook should only install the python REP from the packages directory #176

Open
korydraughn opened this issue Oct 20, 2023 · 0 comments
Labels

Comments

@korydraughn
Copy link
Contributor

Bug Report

The following can break if other plugins exist in the directory and the person running the test hook provides an alternate source for resolving externals packages (i.e. that alternative externals location doesn't contain all the required packages).

if options.do_setup:
built_packages_root_directory = options.built_packages_root_directory
plugin_dir = irods_python_ci_utilities.append_os_specific_directory(built_packages_root_directory)
irods_python_ci_utilities.install_os_packages_from_files([os.path.join(plugin_dir, entry) for entry in os.listdir(plugin_dir)])
irods_python_ci_utilities.subprocess_get_output(['sudo', 'su', '-', 'irods', '-c', 'python3 scripts/setup_python_rule_engine_as_only_rule_engine.py'], check_rc=True)

See the following for what it should do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant