Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support metalbond client creation with proper Context handling #133

Open
afritzler opened this issue Sep 4, 2024 · 0 comments
Open

Support metalbond client creation with proper Context handling #133

afritzler opened this issue Sep 4, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@afritzler
Copy link
Member

Summary

Currently we instantiate the metalbond instance using

mb := metalbond.NewMetalBond(config, metalbondClient)

and initiate a shutdown of the instance via

mb.Shutdown()

It would be better if we would have a contractor method with a proper context. E.g.

mb := metalbond.NewMetalBondWithContext(ctx, config, metalbondClient)

Alternatively we can keep constructor method as is and have a Start(ctx context.Context) method to start the metalbond instance.

@afritzler afritzler added the enhancement New feature or request label Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant