Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

int32 need to be changed to uint32 #3267

Open
erenliu168 opened this issue Jul 17, 2024 · 0 comments
Open

int32 need to be changed to uint32 #3267

erenliu168 opened this issue Jul 17, 2024 · 0 comments

Comments

@erenliu168
Copy link

(NOTE: This is used to report product bugs:
To report a security vulnerability, please visit https://istio.io/about/security-vulnerabilities/
To ask questions about how to use Istio, please visit https://discuss.istio.io
)

Bug description
image
As above, there are some fields in both http and tcp connection pool in DestinationRule which value default to 2^32-1,but the field type is int32。Maybe type of those fields should be changed to uint32 ?

The file is here:
https://github.com/istio/api/blob/master/networking/v1alpha3/destination_rule.pb.go

Affected product area (please put an X in all that apply)

[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[X ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience

Expected behavior
change the type of relative fields to uint32
Steps to reproduce the bug

Version (include the output of istioctl version --remote and kubectl version)

How was Istio installed?

Environment where bug was observed (cloud vendor, OS, etc)

Additionally, please consider attaching a cluster state archive by attaching
the dump file to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants