From cd85494698e627c75308fa69e08035e6eb39d019 Mon Sep 17 00:00:00 2001
From: Daniel Barnes <dabarnes2b@gmail.com>
Date: Fri, 22 Jul 2022 12:26:10 -0700
Subject: [PATCH] clean up

---
 src/drivers/github.js | 40 ++++++++++++++++++++++------------------
 1 file changed, 22 insertions(+), 18 deletions(-)

diff --git a/src/drivers/github.js b/src/drivers/github.js
index 49afa8a1e..b691e2c2f 100644
--- a/src/drivers/github.js
+++ b/src/drivers/github.js
@@ -703,6 +703,27 @@ class Github {
   }
 
   async workflowCheck() {
+    try {
+      // TODO post telemetery merge - only run if in ci?
+      await this.checkWorkflowForTimeoutMinutes();
+    } catch (err) {
+      // noop
+    }
+  }
+
+  get branch() {
+    return branchName(GITHUB_HEAD_REF || GITHUB_REF);
+  }
+
+  get userEmail() {
+    return 'action@github.com';
+  }
+
+  get userName() {
+    return 'GitHub Action';
+  }
+
+  async checkWorkflowForTimeoutMinutes() {
     const WARNINGS = [];
     const _DIR = '.github/workflows/';
     const yaml = require('js-yaml');
@@ -714,7 +735,6 @@ class Github {
         // does job contain timeout?
         const timeoutVal = doc.jobs[job]['timeout-minutes'];
         if (timeoutVal === undefined) return;
-
         // does job have label runs-on "self-hosted" or "cml"
         const runsOn = doc.jobs[job]['runs-on'];
         switch (typeof runsOn) {
@@ -735,15 +755,12 @@ class Github {
                   );
                 })
                 .reduce((pv, v) => pv || v)
-            ) {
+            )
               return;
-            }
             break;
           default:
             return;
         }
-
-        console.log('found timeout in job:', job);
         // locate timeout for warning
         const warning = (function (find) {
           const lines = rawStr.split('\n');
@@ -770,19 +787,6 @@ class Github {
         `::warning file=${warning.file},line=${warning.line},title=Possible Unexpected Behavior using "cml runner"::GitHub Actions has updated timeout-minutes if your job is unlikely to run longer than 6hrs then you should remove timeout-minutes, to have cml auto-restart for long training jobs change this value to: 50400 (35d)`
       );
     }
-    process.exit();
-  }
-
-  get branch() {
-    return branchName(GITHUB_HEAD_REF || GITHUB_REF);
-  }
-
-  get userEmail() {
-    return 'action@github.com';
-  }
-
-  get userName() {
-    return 'GitHub Action';
   }
 }