From a7b0eed0d640e9debfa8e239c58f442dd911ebe9 Mon Sep 17 00:00:00 2001 From: skshetry <18718008+skshetry@users.noreply.github.com> Date: Tue, 6 Feb 2024 00:01:13 +0545 Subject: [PATCH] TqdmCallback: fix typo/off-by-one error (#277) `self.tqdm` should be set if progress_bar is passed. --- src/dvc_objects/fs/callbacks.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/dvc_objects/fs/callbacks.py b/src/dvc_objects/fs/callbacks.py index 467e26a..df80b5e 100644 --- a/src/dvc_objects/fs/callbacks.py +++ b/src/dvc_objects/fs/callbacks.py @@ -41,11 +41,10 @@ def __init__( from dvc_objects._tqdm import Tqdm tqdm_kwargs.pop("total", None) - tqdm_cls = tqdm_cls or Tqdm super().__init__( - tqdm_kwargs=tqdm_kwargs, tqdm_cls=tqdm_cls, size=size, value=value + tqdm_kwargs=tqdm_kwargs, tqdm_cls=tqdm_cls or Tqdm, size=size, value=value ) - if progress_bar is None: + if progress_bar is not None: self.tqdm = progress_bar def branched(self, path_1: "Union[str, BinaryIO]", path_2: str, **kwargs):