Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Newtonsoft.Json from 10.0.3 to 13.0.1 to fix the vulnerability. #1227

Open
kerembalaban opened this issue Feb 5, 2024 · 0 comments
Open

Upgrade Newtonsoft.Json from 10.0.3 to 13.0.1 to fix the vulnerability. #1227

kerembalaban opened this issue Feb 5, 2024 · 0 comments

Comments

@kerembalaban
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch [email protected] for the project I'm working on.

Here is the diff that solved my problem:

diff --git a/node_modules/react-native-fs/windows/RNFS.Net46/packages.config b/node_modules/react-native-fs/windows/RNFS.Net46/packages.config
index b427c04..357e523 100644
--- a/node_modules/react-native-fs/windows/RNFS.Net46/packages.config
+++ b/node_modules/react-native-fs/windows/RNFS.Net46/packages.config
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
 <packages>
-  <package id="Newtonsoft.Json" version="10.0.3" targetFramework="net46" />
+  <package id="Newtonsoft.Json" version="13.0.2" targetFramework="net46" />
   <package id="Syroot.Windows.IO.KnownFolders" version="1.2.1" targetFramework="net46" />
 </packages>
\ No newline at end of file

This issue body was partially generated by patch-package.
DmitriyKirakosyan added a commit to microsoft/appcenter-sdk-react-native that referenced this issue Jan 28, 2025
@DmitriyKirakosyan
Replace react-native-fs with react-native-file-access
9e03f6e 
react-native-fs has a known vulnerability itinance/react-native-fs#1227.
Since it is not maintained anymore, I replaced it with react-native-file-access.

Additionally, fixed the photo picker library usage.
@DmitriyKirakosyan DmitriyKirakosyan mentioned this issue Jan 28, 2025
Merged
DmitriyKirakosyan added a commit to microsoft/appcenter-sdk-react-native that referenced this issue Jan 28, 2025
@DmitriyKirakosyan
Replace react-native-fs with react-native-file-access (#1056)
dc10b93 
react-native-fs has a known vulnerability itinance/react-native-fs#1227.
Since it is not maintained anymore, I replaced it with react-native-file-access.

Additionally, fixed the photo picker library usage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kerembalaban