Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing option label translations #14

Open
Baedda opened this issue Jun 8, 2022 · 2 comments
Open

Missing option label translations #14

Baedda opened this issue Jun 8, 2022 · 2 comments

Comments

@Baedda
Copy link
Contributor

Baedda commented Jun 8, 2022

Hey guys,

I noticed that thanks to the Pull request by @Weggla you now have german translations for the options. I checked them out in our Iframely CMS integration but unfortunately there are missing translations for some options. For that reason I had a closer look at your labels.LAN.example.js and noticed, that the missing translations are already missing in your example file.

Here is a list of missing options I found during my tests:

YouTube:

  • Closed captions

Vimeo:

  • Text language (ignored if no captions)
  • Two letters: en, fr, es, de...

Twitter:

  • Use dark theme
  • Adjust width

Kickstarter:

  • Don't include attached player
  • Attached player only, no card

But there could be more, that I didn't spot yet. Could you please update the example file with all missing options? After that I could help you out by translating the new options to german.

Thanks,
Chris

@iparamonau
Copy link
Member

Thanks. It's a bit tricky at the moment to gather all options from varying sources. We'll discuss what we can do, but it is unlikely to be a quick fix. Perhaps it's easier to open a PR right away for the options that you've discovered.

@Baedda
Copy link
Contributor Author

Baedda commented Jun 8, 2022

@iparamonau so I did :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants