Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated your mod to 1.21, Request to commit? #11

Open
handsome-steve opened this issue Jun 25, 2024 · 5 comments
Open

Updated your mod to 1.21, Request to commit? #11

handsome-steve opened this issue Jun 25, 2024 · 5 comments

Comments

@handsome-steve
Copy link

So as the title says, I updated your mod to 1.21 to play on my private server with friends (not looking to distribute it or anything).

I figured that you may want to skip having to do it yourself and have a read through the code.
I am happy to commit the update to the repository if you would like.
FYI, no changes have been made to the mod functionality nor have there been any additions regarding blocks, block-entities, items or entities, its all your content, just updated for "Fabric 1.21".

Let me know if that interests you! 😊

image_d
image_c
image_b
image_a

@iuriineves
Copy link
Owner

This is great! If you don't mind opening a pull request, I'd be more than happy to have a read through the changes! Thanks.

@handsome-steve
Copy link
Author

handsome-steve commented Jun 26, 2024

Done 😊
Just a heads up in case you haven't had a chance to look at it yet, Gradle requires 'Java Version 21' instead of 'Java Version 17' for 'Fabric 1.21' .

@handsome-steve
Copy link
Author

handsome-steve commented Jun 27, 2024

Hey, just thought I'd mention that we did some further testing during our 1.21 multiplayer playthrough and found several bugs regarding advancements, loot tables, and structures, which I am revising and pushing, I'll fix those other bugs and make another push request a little later today so it reflects on the pull request.😊
Just let me know if you find any bugs etc and I'm happy to just fix them up.

@handsome-steve
Copy link
Author

Pushed the changes 🐱‍👤

@handsome-steve
Copy link
Author

Hey, just saw that you tried to run a check, it might be a good idea to push these changes to a new branch.
I can't select a 1.21 branch until you make one. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants