Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fullscreen mode sometimes immediately exits after activation #4286

Open
raxod502 opened this issue Nov 22, 2023 · 2 comments · May be fixed by #4439
Open

[Bug] Fullscreen mode sometimes immediately exits after activation #4286

raxod502 opened this issue Nov 22, 2023 · 2 comments · May be fixed by #4439
Labels
bug Something isn't working

Comments

@raxod502
Copy link

Describe the bug
Under some circumstances, attempting to enter fullscreen mode will activate fullscreen but then automatically deactivate it a moment later. The behavior repeats no matter how many times the user attempts to enter fullscreen mode. Sometimes, restarting the app or device prevents the bug from occurring. However, after at least one video has been played and the user navigates to another one, the behavior recurs.

Steps to Reproduce

  1. Open an Invidious instance in Firefox
  2. Open a video
  3. Enter fullscreen
  4. If the behavior does not occur, leave fullscreen and enter again
  5. If the behavior does not occur, leave fullscreen, go back to the previous page, open a new video, enter fullscreen again
  6. Behavior reproduces, I have yet to see any case where it does not happen by now

Logs
The console logs are not accessible in mobile browsers to my knowledge

Screenshots
Screen recording here: https://nextcloud.intuitiveexplanations.com/s/qiGHmiZy659fpNJ

Additional context
The screen recording shows Invidious installed as a shortcut on the home screen, but the same behavior occurs when browsing directly to it in Firefox. Also, the screen recording shows my self-hosted Invidious instance at https://youtube.intuitiveexplanations.com, but the same behavior occurs with https://yewtu.be.

  • OS: GrapheneOS (Android 14)
  • Browser: Firefox (119.0)
@raxod502 raxod502 added the bug Something isn't working label Nov 22, 2023
@raxod502
Copy link
Author

raxod502 commented Mar 3, 2024

FYI: This issue is resolved by upgrading video.js dependency:

 video.js:
-  version: 7.12.1
-  shasum: 1d12eeb1f52e3679e8e4c987d9b9eb37e2247fa2
+  version: 8.9.0
+  shasum: 0d8ea582e8d10eccf82ae16760b3829fa91442e3

Although that brings in other issues and breakage as mentioned in #3011 and related.

@unixfox
Copy link
Member

unixfox commented Mar 3, 2024

FYI: This issue is resolved by upgrading video.js dependency:

 video.js:
-  version: 7.12.1
-  shasum: 1d12eeb1f52e3679e8e4c987d9b9eb37e2247fa2
+  version: 8.9.0
+  shasum: 0d8ea582e8d10eccf82ae16760b3829fa91442e3

Although that brings in other issues and breakage as mentioned in #3011 and related.

#4439

@unixfox unixfox linked a pull request Mar 4, 2024 that will close this issue
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants