Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration to Manifest Version 3 #108

Closed
izzy opened this issue Jul 9, 2021 · 2 comments
Closed

Migration to Manifest Version 3 #108

izzy opened this issue Jul 9, 2021 · 2 comments

Comments

@izzy
Copy link
Owner

izzy commented Jul 9, 2021

A newer version of the manifest exists requiring some overhaul in the general architecture of the extension.

As with the last manifest version, this opens the door(and in some cases need) for some refactoring.

More info:

Given this will be a major overhaul, once the changes are in, the extension should hop to a 5.0.0

@izzy
Copy link
Owner Author

izzy commented Oct 23, 2021

There is a known issue in manifest v3 that makes chrome.i18n.getMessage unavailable for creating context menus from the background page:

1159438 - chrome.i18n.getUILanguage API unavailable from manifest v3 extension's background ServiceWorker - chromium

While chrome.i18n.getUILanguage is supposedly available building anything around that function would be a lot of work while being janky at best. Therefor not buiilding the extension aroudn i18n.getMessage seems like a waste of time.

See also w3c/webextensions#93

@izzy
Copy link
Owner Author

izzy commented Jan 31, 2022

The issue seems fixed in the current canary version(100.x), which should become beta in March and stable in April. https://bugs.chromium.org/p/chromium/issues/detail?id=1268098#c11

izzy added a commit that referenced this issue Oct 19, 2022
@izzy izzy closed this as completed in eef9995 Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant