Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requests with '+' are converted to ' ', even when urlencoded as '%2b' #111

Open
tyzoid opened this issue Apr 23, 2018 · 0 comments
Open

Comments

@tyzoid
Copy link
Collaborator

tyzoid commented Apr 23, 2018

Demonstration of the issue:

$ curl https://apilabs.tyzoid.com/api/hello/test/test++
{
    "message_a": "Hello test",
    "message_b": "Hello test  "
}

Changing

if (preg_match(":^$regex$:", urldecode($this->url), $matches)) {

to

if (preg_match(":^$regex$:", $this->url, $matches)) {

in findUrl() fixes this issue, but investigation is needed to ensure this does not break other intended functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant