Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leave command unhandled exception #77

Open
jahschwa opened this issue Apr 23, 2020 · 0 comments
Open

leave command unhandled exception #77

jahschwa opened this issue Apr 23, 2020 · 0 comments
Assignees

Comments

@jahschwa
Copy link
Owner

This probably happened because the bot was inactive in the XMPP room specified in the chat command. It's likely the logic in determining room is slightly off in the leave command. The result was sending a Matrix room object to the XMPP part_room() method, which raised an unhandled exception.

  1. The leave command should catch exceptions from part_room()
  2. Audit room determination logic.
2020-04-23 18:08:09 | sibylbot | ERR | Error while executing cmd "leave":
2020-04-23 18:08:09 | sibylbot | ERR |   KeyError: u'!matrixid:domain.net'
2020-04-23 18:08:09 | sibylbot | DEB |   Message text: "#leave xmpp:[email protected]"
2020-04-23 18:08:09 | sibylbot | DEB | Traceback (most recent call last):
  File "/home/sibyl/sibyl/lib/sibylbot.py", line 611, in _cb_message
    reply = func(self,mess,args)
  File "cmds/room.py", line 244, in leave
    proto.part_room(room)
  File "protocols/sibyl_xmpp.py", line 348, in part_room
    if self.mucs[name]['status']==self.MUC_OK:
KeyError: u'!matrixid:domain.net'
@jahschwa jahschwa self-assigned this Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant