Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PromiseInterface has not done object #141

Closed
AbrahamCovelo opened this issue Aug 7, 2023 · 2 comments
Closed

PromiseInterface has not done object #141

AbrahamCovelo opened this issue Aug 7, 2023 · 2 comments
Labels

Comments

@AbrahamCovelo
Copy link

Taking a look a this line done method does not exist for a React\Promise\PromiseInterface

$this->flushWriteBuffer()->done(function () {

It has produces some errors in my project

In Client.php line 340:

Attempted to call an undefined method named "done" of class "React\Promise\Promise".

@WyriHaximus
Copy link
Collaborator

This package doesn't target promise v3 yet:

"react/promise": "~2.2"

So how are you getting that error?

P.S. Don't get me wrong, happy to see more and more people using Promise v3 but that shouldn't happen when you use this package yet.

@WyriHaximus WyriHaximus added the bug label Aug 8, 2023
@WyriHaximus
Copy link
Collaborator

Closing this as #147 landed promise v3 for the upcoming 0.6 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants