Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: displaying incorrect value for paid invoices in success notification #1107

Open
Abdulkbk opened this issue Jan 16, 2025 · 2 comments · May be fixed by #1110
Open

Bug: displaying incorrect value for paid invoices in success notification #1107

Abdulkbk opened this issue Jan 16, 2025 · 2 comments · May be fixed by #1110
Labels
bug Something isn't working

Comments

@Abdulkbk
Copy link
Contributor

Describe the bug
After successfully paying an invoice, the success alert card does not display the correct value paid. I tried this with 3 different Lightning implementations (LND, C-Lightning, and Eclair) and got the same result.

For example, I created a network with the 3 LN nodes and opened channels as follows:

  • Alice (LND) -> Bob (C-lightning)
  • Bob (C-lightning) -> Carol (Eclair)

I then created an invoice of 1,000,000 sats using Carol and paid it using Bob. I got "sent 1 sat from bob":

Image

I created another invoice for 20,000 using Bob and paid it with Alice. I received "sent 20 sat from alice."

Image

Interestingly, this bug occurs when I run yarn dev on the latest master. It is not present when I test in release 3.0.0, AFAIK.

To Reproduce
Steps to reproduce the behavior:

  1. Ensure you have the most current version of the master branch.
  2. Set up a network with multiple Lightning nodes.
  3. Generate an invoice with one node and pay it using another.
  4. Pay close attention to the success notification.

Expected behaviorThe expected outcome is to receive the accurate amount of the invoice that has been paid, in the success notification.

Screenshots
Example:

Image

Image

Image

Desktop (please complete the following information):

  • OS: Ubuntu 22.04
  • Polar Version: 3.2.0 (latest master)
  • Docker Version: 27.4.1
  • Docker Compose Version: 2.32.1

Additional context
Add any other context about the problem here.

@Abdulkbk Abdulkbk added the bug Something isn't working label Jan 16, 2025
@Abdulkbk Abdulkbk changed the title Bug: Bug: displaying incorrect value for paid invoices in success notification Jan 16, 2025
@Abdulkbk
Copy link
Contributor Author

Abdulkbk commented Jan 17, 2025

I just tested this on Windows and encountered the same issue.

Desktop:

  • OS: Windows 11
  • Polar Version: 3.2.0 (latest master)
  • Docker Version: 27.4.0
  • Docker Compose Version: 2.31.0-desktop.2

@AdamuAbba
Copy link
Contributor

AdamuAbba commented Jan 17, 2025

Hey, @Abdulkbk I just tested and can confirm the same behavior on MacOS.

Desktop:

  • OS: MacOS Sequoia 15.2 (24C101)
  • Polar Version: 3.2.0 (latest master)
  • Docker Version: 27.4.0
  • Docker Compose Version: 2.31.0-desktop.2

I'm gonna do some more digging into the issue and create a PR to address it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants