Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BuildEndurance/Health do not handle Base*Bonus properly #93

Open
seraku24 opened this issue Jan 10, 2023 · 0 comments · May be fixed by #94
Open

BuildEndurance/Health do not handle Base*Bonus properly #93

seraku24 opened this issue Jan 10, 2023 · 0 comments · May be fixed by #94

Comments

@seraku24
Copy link

The logic for handling each mod's respective Base*Bonus is pulling data from PlayerData rather than Config. When there is no PlayerData yet, it gets an initial value of zero rather than the value specified in config.json. This value probably should not be included in PlayerData, as it never changes per player, and instead should be referenced directly from Config.

I am willing to submit a PR for this. I would just need to get a build environment set up first, so I can test the proposed fix locally.
seraku24 added a commit to seraku24/janavarro95-Stardew_Valley_Mods that referenced this issue Jan 10, 2023
@seraku24
Correctly handle base bonuses; other fixes.
95e87e9 
Fixes janavarro95#93.

Applies to BuildEndurance and BuildHealth:
- ModConfig no longer includes data that is player-specific.
- PlayerData no longer includes data that is configuration-specific.
- PlayerData is properly initialized for new players.
- Maximum health/stamina factors in configured base bonus.
- Current health/stamina is clamped by maximum as needed.

Applies to BuildEndurance:
- Manifest description corrected.

Applies to BuildHealth:
- Player-specific data is saved at the end of the day.
@seraku24 seraku24 linked a pull request Jan 10, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correctly handle base bonuses; other fixes. seraku24/janavarro95-Stardew_Valley_Mods
1 participant
@seraku24