Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speech bubbles deserve corners #12

Open
austin3dickey opened this issue Feb 1, 2019 · 1 comment
Open

Speech bubbles deserve corners #12

austin3dickey opened this issue Feb 1, 2019 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@austin3dickey
Copy link

Hi @jayqi ,

Thanks for this package; it's really helped me advance in my work.

I think Spongebob's speech bubbles deserve to look a bit nicer with corners. This wikipedia page points out some great ASCII characters that can create nice-looking ASCII boxes. I've used some in slaph.

@jayqi
Copy link
Owner

jayqi commented Feb 9, 2019

These look like Unicode characters. I think this should still work fine, but I'd like to do some more testing/research to understand them and make sure they print as expected. In particular, when will UTF-8 printing fail?

I think some of the other stuff I have generally could be improved with Unicode as well.

@jayqi jayqi added enhancement New feature or request help wanted Extra attention is needed labels Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants