Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing "start" enumeration com.eatthepath.pushy.apns.util.LiveActivityEvent #1047

Closed
soda-universe opened this issue Jan 10, 2024 · 2 comments · Fixed by #1049
Closed

Missing "start" enumeration com.eatthepath.pushy.apns.util.LiveActivityEvent #1047

soda-universe opened this issue Jan 10, 2024 · 2 comments · Fixed by #1049
Milestone

Comments

@soda-universe
Copy link

The official apns documentation requires the event to be specified as start, but pushy does have this enumerated value.

https://developer.apple.com/documentation/activitykit/starting-and-updating-live-activities-with-activitykit-push-notifications#Construct-the-payload-that-starts-a-Live-Activity

What do you think about it?

@jchambers
Copy link
Owner

It looks like something changed upstream, likely with the latest iOS release. The old documentation link (https://developer.apple.com/documentation/activitykit/update-and-end-your-live-activity-with-remote-push-notifications) now redirects to the link you provided, and (strangely) makes no mention of the "end" event any more. It's unclear to me if this is a deliberate change or just a mistake in the documentation.

In any case, I've opened #1049 to add the "start" event type.

@soda-universe
Copy link
Author

It looks like something changed upstream, likely with the latest iOS release. The old documentation link (https://developer.apple.com/documentation/activitykit/update-and-end-your-live-activity-with-remote-push-notifications) now redirects to the link you provided, and (strangely) makes no mention of the "end" event any more. It's unclear to me if this is a deliberate change or just a mistake in the documentation.

In any case, I've opened #1049 to add the "start" event type.

thanks, when is v0.15.4 expected to be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants