Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some edges are colored incorrectly #6

Open
jdan opened this issue Apr 27, 2014 · 5 comments
Open

Some edges are colored incorrectly #6

jdan opened this issue Apr 27, 2014 · 5 comments

Comments

@jdan
Copy link
Owner

jdan commented Apr 27, 2014

If you look at the drawing on the project page closely, you'll see the following:

screen shot 2014-04-27 at 3 04 55 pm

There's a small "hairline" crack in the shape - essentially a discolored edge. This occurs when a portion of a hidden face creeps up. Might be due to floating point coordinates.

@rcmaniac25
Copy link
Contributor

If you make a rotating light, you will find a fair number of extra ones

@ooflorent
Copy link
Contributor

Might be due to floating point coordinates.

I tried to use plain integers but it didn't solve the issue.
I think this is related to #25.

@rcmaniac25
Copy link
Contributor

I have a feeling it has to do with antialiasing.

Draw path, edges are antialiased (I think), draw path next to prior path, edges are antialiased.

Multiple antialiased objects work well together within 3D, as they are all antialiased together. But when drawn one at a time, their edges don't line up.

I could be wrong, I'm just guessing.

@FabrizioC
Copy link

@ooflorent nope, you can try but the edges still persists.
The "pixel iso angle" is useful to mix calculated objects with "iso pictures" could be overlapped.

@Mysterix
Copy link

Is it really a bug ? After all, what is the color of an edge ? Which of the faces give it its color ?

A partial solution would be to do not display faces that are completely hidden (doable with path ordering (see the other topic)). This does not cover all possible cases, but among other cases it covers the one shown here.
A better solution would have a look at the neighborhood of the edge and consider faces parts that are actually displayed, seems tricky...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants