Issue with Unpausing withSpacebar.

[levrx]

Description of the bug

You try to play, it pauses when you play.

Steps to reproduce

Go onto a show or movie, press the pause button with your mouse then try to unpause with your spacebar.

Expected behavior

You try to play, it pauses when you play.

Logs

No response

Screenshots

No response

Platform

Windows

Browser

Other (Please specify in the "additional context" section)

Jellyfin server version

10.9.2

Additional context

Brave

[manicExpressive]

Interesting bug! This seems to be a result of the pausePlayButton still being targeted in the DOM, so the space bar is doing the normal thing it does when nothing is targeted (pausing and playing the video) and also doing the click action on the pausePlayButton.

I'm not super deep on modern Vue so I went poking around and quickly realized doing a @click.once here on PlayPausebutton.vue wasn't the move as it would disable the play button after the first click!

A little special casing for the space bar might be the best way to tackle the bug, but this might also be a good spot for someone who loves keyboard shortcuts to add some finesse.

[ferferga]

@manicExpressive @levrx Please give this a go at #2383

This is a quick solution I came up at this moment, though I think it's better if the global handlers simply focused and passed the event to the relevant buttons (like YouTube does). This is, however, a bit difficult at this moment due to Vuetify handling focus on it's own, instead of focusing the underlying button element. This is one of the reasons why I want to drop it and roll our own components based on it (faster updates and fix of these nnoying quirks).

@manicExpressive A new contributor would be awesome! 🎉

[manicExpressive]

Rad, thanks for taking a look - I followed up over on the PR with a quick suggestion, not super sure if their are broader implications beyond “works for me” :D