From 9d0a12d7fc3b3a28f2ad125dbe1040888d25a609 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?M=C3=A5rten=20Svantesson?= Date: Tue, 19 Dec 2023 16:11:46 +0100 Subject: [PATCH] fix: run_if_changed test When checking if the issue jenkins-x/jx#8477 was still valid I noticed that this test a) Tested the wrong thing b) Expected the wrong result Now fixed --- pkg/plugins/trigger/generic-comment_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/plugins/trigger/generic-comment_test.go b/pkg/plugins/trigger/generic-comment_test.go index 655a9aa09..cbc7e5a1f 100644 --- a/pkg/plugins/trigger/generic-comment_test.go +++ b/pkg/plugins/trigger/generic-comment_test.go @@ -709,7 +709,7 @@ func TestHandleGenericComment(t *testing.T) { name: "explicit /test for RunIfChanged job that doesn't need to run", Author: "trusted-member", - Body: "/test pull-jeb", + Body: "/test jeb", State: "open", IsPR: true, Presubmits: map[string][]job.Presubmit{ @@ -729,7 +729,7 @@ func TestHandleGenericComment(t *testing.T) { }, }, }, - ShouldBuild: false, + ShouldBuild: true, }, { name: "/test all of run_if_changed job that has passed and needs to run",