Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sounds not played in Build Monitor tab #159

Closed
ciaranmccarthy opened this issue Jul 1, 2015 · 8 comments
Closed

Sounds not played in Build Monitor tab #159

ciaranmccarthy opened this issue Jul 1, 2015 · 8 comments

Comments

@ciaranmccarthy
Copy link

When displaying the Build Monitor Plugin in a tab in a web browser, sounds played using the Jenkins Sounds plugin aren't played in the Build Monitor Plugin tab.

Sounds were played when using the previous version of the Build Monitor Plugin (1.6+build.149).

Version information:
Build Monitor Plugin 1.6+build.150
Jenkins Sounds plugin 0.4.3 (https://wiki.jenkins-ci.org/display/JENKINS/Jenkins+Sounds+plugin)
Jenkins 1.618
Google Chrome 43.0.2357.130 m
Windows 7 Service Pack 1

(We have a dedicated screen in our development team showing current build statuses, and playing a happy 'ding!' sound when everything goes well, or a loud obnoxious 'buzz' when everything doesn't!)

@jan-molak
Copy link
Member

Thanks for reporting this, I'll have a look.
I wasn't aware that Build Monitor is being used with the Sounds plugin.
Sounds like a cool combo! (no pun intended ;) )

related: #24

@ciaranmccarthy
Copy link
Author

Magic, thanks for having a look. Yeah, the screen and the sounds are really useful. Apart from when the boss comes in and asks why nearly everything is red. :D

The team here at beyontics say thanks for your excellent plugin! Especially our boss.

@jan-molak
Copy link
Member

@ciaranmccarthy - Thanks, your kind words are much appreciated :)

I'm happy to announce that as of v1.6+build.154 you and your team at beyontics no longer have to live in silence and may enjoy the "loud obnoxious 'buzz'" again!

Although I do wish you and your boss that you don't have to hear that sound too often 😉

@jordy93
Copy link

jordy93 commented Jan 27, 2017

I think this feature isn't working anymore? I hear nothing on my build monitor tab :(

@jan-molak
Copy link
Member

@jordy93 - what version of Build Monitor/Jenkins/Jenkins Sounds Plugin are you using please?

@jordy93
Copy link

jordy93 commented Jan 30, 2017

Hi Jan,

Thanks for the quick response, I'm using these verions:

Build Monitor View - 1.11+build.201701152243
Sounds plugin - 0.5
Jenkins - 2.32.1

@bascht
Copy link

bascht commented Feb 16, 2017

@jan-molak @jordy93 we trapped into the same issue:

The sound monitor plugin injects a bit of JavaScript that still requires prototype.js:

new Ajax.Request("/sounds/getSounds", 
{
        parameters: { version: VERSION },
        onSuccess: function(rsp) {
        onSuccess(eval('x='+rsp.responseText))
    },
  onFailure: onFailure
});

And it looks like 321cfb2 removed Prototype.js to fix #217.

So this is a bit of a dead end.
It might be easier to just fix that bit of JS for the Sound Plugin. 😉

bascht added a commit to bascht/sounds-plugin that referenced this issue Feb 16, 2017
Remove the `Prototype.js` dependency of the Sound Plugin in favour of
a plain JavaScript XMLHttpRequest().

See also jenkinsci/build-monitor-plugin#159
@jan-molak
Copy link
Member

Lol, cool, thanks for the update! Yes, that sounds like a sensible approach :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants