-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipelines integartion #24
Comments
@lessless Hi, Could you find solution for Flowdoc with pipelines? Thanks for answer:) |
@danielsaf no luck so far, I'm planning to open a topic on the CA support forums, because of supporting point&click interface is quite resourceful. |
@danielsaf I was advised to leave a suggestion in customer support where other users can vote on it too |
@lessless This is what I'm doing for now, assuming you have a unix node with curl installed, it replicates most of the functionality of flowdock inbox notifications. Add to your Jenkinsfile:
Call it like this: |
Awesome @danielsaf! Thank you for bringing that into life 👍 |
No it should just work like that in your Jenkinsfile |
@ndobson I'm afraid the script that we are using is prone to RCE exploitation because of notification is sent via bash script and |
@lessless You can use the httpRequest step from the HTTP Request Plugin rather than shell out to curl, i.e.:
|
@mletterle thanks a lot! |
I hacked together a pretty basic shared library to make the function reusable across builds without copying/pasting. Comments etc. welcome. It would be better to extend the Flowdock notification plugin to work with Pipeline, but that's for another day perhaps. :) My thanks to the people who've contributed to this thread, especially @lessless for raising the issue and @ndobson for most of the code I used. |
Thanks @dleske, not that useful for a lot of people because you slapped a GPL license on it (and it's not even your code) which would require anyone using it to slap a GPL license on all their Jenkinsfiles. |
@cybertiger: The intent wasn't to steal the ideas or code of the earlier posters. The minor work I did added some code and under the project I was on, any code written was obliged to be released under the GPL. The original code can still be used and modified, and I'm not sure using the library requires the users' Jenkinsfiles to be GPLed. |
Yeh no worries, the pipeline library is a cool thing. |
Note: that the original API this uses is depreciated. https://www.flowdock.com/api/team-inbox I have added a pull request updating this functionality. Using the REST API & added in the ability to differentiate between inbox & flow messages. |
Hello,
Thank you for useful plugin. It will be really wonderful to be able to use it with pipelines
https://jenkins.io/blog/2016/05/25/update-plugin-for-pipeline/
https://github.com/jenkinsci/pipeline-plugin/blob/master/DEVGUIDE.md
The text was updated successfully, but these errors were encountered: