Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Security Hotspots failures ignored when reporting to Gerrit #140

Open
felipecrs opened this issue Apr 5, 2023 · 0 comments
Open

New Security Hotspots failures ignored when reporting to Gerrit #140

felipecrs opened this issue Apr 5, 2023 · 0 comments
Labels

Comments

@felipecrs
Copy link

Jenkins and plugins versions report

Latest everything :)

What Operating System are you using (both controller, and any agents involved in the problem)?

Docker

Reproduction steps

  • Run a pre-submit build with SonarQube configured in pull request mode (I'm using the community plugin) and Sonar Gerrit
  • In this pre-submit, introduce a Security Hotspot issue like: e.printStackTrace() in the code.

Expected Results

For Sonar Gerrit to report the failure just like code smells, for example. The quality gate in SonarQube itself is marked as failing because of this new security hotspot:

image

image

If waitForQualityGate is called in Jenkins, it also returns the failing status:

CDViewer_ks6GAjZK8c

Actual Results

Sonar Gerrit ignores the security hotspot failure, votes back a +1 to the change request.

Ideally it should vote according to the quality gate result, and should also post comments for security hotspots.

Anything else?

No response

@felipecrs felipecrs added the bug label Apr 5, 2023
@felipecrs felipecrs changed the title New Security Hotspots not being taken into account when reporting to Gerrit New Security Hotspots failures ignored when reporting to Gerrit Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant