-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
file based splits #108
Comments
Cherry on top would be being able to recover these groups by name so I can label in other CI/CD |
Let's first align on the naming:
I think the pragmatic solution would be to ensure that tests within a single module are ran in the same group. If the algorithm would also take into accounts packages, it'd easily get complex as there can be basically endless level of nesting with packages. Considering implementation, I think there are two options:
I'd favour 1. as there are also needs for "no splits for classes" (e.g. #82) so 1. would be a better choice considering future development. I believe there'd be many use cases for this so happy to take a PR if someone wants to give it a shot. |
@wd60622 what do you mean by this? |
I would like to be able to know which files / modules are in each group. This issue's body is the motivation: pymc-labs/pymc-marketing#1158 where I display the groups in a GitHub Issue. |
Thanks for clarifying the problem a bit @jerry-git Are you imagining that the For instance, # Same behavior as before
pytest --splitting-algorithm=duration_based_chunks
# New behavior
pytest --splitting-algorithm=duration_based_chunks --no-module-splits Where the |
I'm interested in file based splits in order to keep modules together
For example:
A split might be like
a.py and b.py
,sub_module
, andanother_sub_module
The text was updated successfully, but these errors were encountered: