Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fw4 Counter #8

Open
hudra0 opened this issue Jan 1, 2023 · 5 comments
Open

Fw4 Counter #8

hudra0 opened this issue Jan 1, 2023 · 5 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@hudra0
Copy link

hudra0 commented Jan 1, 2023

It would be nice to have an option to turn on counter in firewall to quickly check if a rule is working.

@jeverley
Copy link
Owner

jeverley commented Jan 5, 2023

Hi @hudra0, you should find this this capability now in the latest commits.

You can turn this on for a particular rule by setting the new boolean config option of 'counter' to 1.

Let me know if you've any feedback/thoughts.

@hudra0
Copy link
Author

hudra0 commented Jan 8, 2023

Let me know if you've any feedback/thoughts

Just switched to your branch and it works, thank you. The only concern I have is that new users could be confused as the rule counters only count matched connections and not every single packet.

Maybe a hint in the readme would be helpful and reduce questions regarding counters not increasing.

Or is there any way to get counters for every packet directly from conntrack?

Another thing that would also be helpful is some sort of status + maybe a help section with all the possible init.d commands….

@jeverley
Copy link
Owner

jeverley commented Jan 9, 2023

Good suggestion regarding the readme, when it comes to per-connection 'reporting' I wonder if something like the @ldir-EDB0 's patch in openwrt/luci@183db13 might better meet people's expectations?

It displays the stored DSCP alongside other stats in Luci's existing 'realtime graphs -> connections' page

@hudra0
Copy link
Author

hudra0 commented Jan 9, 2023

I think this would be a solid addition/replacement to the fw4 counter but this is just my personal opinion.

@francisuk1989
Copy link

It displays the stored DSCP alongside other stats in Luci's existing 'realtime graphs -> connections' page

I would like to this feature to see what Marked 👍

@jeverley jeverley added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants