Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable deployment through HTTP proxy #14

Closed
OliverMatz opened this issue Apr 26, 2021 · 2 comments · Fixed by #18 or #64
Closed

Enable deployment through HTTP proxy #14

OliverMatz opened this issue Apr 26, 2021 · 2 comments · Fixed by #18 or #64
Labels
feature request New feature or request

Comments

@OliverMatz
Copy link

OliverMatz commented Apr 26, 2021

Our maven build runs on a machine that can connect to the internet only via an HTTP-proxy. The target nexus artifactory is only available via the internet. Although the http proxy is correctly configured (1) in the file .m2/settings.xml and (2) in the four environment variables [http[s]_(proxy|port)] and (3) in the four java standard system properties http[s].proxy(Host|Port), the artifactory-maven-plugin does not use and the attempt to deploy to the nexus artifactory fails with an exception:
{noformat}
[ERROR] Internal error: java.lang.RuntimeException: java.util.concurrent.ExecutionException: java.lang.RuntimeException: Error occurred while publishing artifact to Artifactory: ...
[ERROR] Skipping deployment of remaining artifacts (if any) and build info. Connect to targethost.de:443 [targethost.de/111.22.33.44] failed: Connection timed out: connect
{noformat}

I would like to see some documented way to use the http proxy. Preferrably, the artifactory-maven-plugin should use the http proxy configured in the file .m2/settings.xml, but I would be happy with any other reliable way that somehow fits into the configuration framework.

Additional context

  • This feature has been requested before: http://forums.jfrog.org/Maven-Artifactory-Plugin-setting-http-proxy-td7579782.html
  • Other maven plugins do use our http proxy correctly
  • There is quite a lot of preparation in the present code (3.2.1), e.g. class org.jfrog.build.extractor.clientConfiguration.ArtifactoryClientConfiguration.ProxyHandler, but it does not seem to be actually used.
  • I have found a simple fix that works for me and which I plan to submit as a pull request
@OliverMatz OliverMatz added the feature request New feature or request label Apr 26, 2021
@OliverMatz
Copy link
Author

pending pull request: #15

@yahavi
Copy link
Member

yahavi commented Jun 6, 2021

@OliverMatz,
Thanks for reporting this issue.

Maven Artifactory plugin 3.2.3 is released.
This version should include the fix for this issue - feel free to upgrade.

We'd appreciate your feedback on that.

@yahavi yahavi linked a pull request Jun 6, 2021 that will close this issue
1 task
@yahavi yahavi linked a pull request Mar 25, 2023 that will close this issue
1 task
@yahavi yahavi closed this as completed in #64 Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
None yet
2 participants