Skip to content
This repository has been archived by the owner on Sep 28, 2021. It is now read-only.

Unclear README.md description #137

Open
ProductOfAmerica opened this issue Jun 14, 2017 · 0 comments
Open

Unclear README.md description #137

ProductOfAmerica opened this issue Jun 14, 2017 · 0 comments

Comments

@ProductOfAmerica
Copy link

ProductOfAmerica commented Jun 14, 2017

This function is unclear:

function onAuthorizeSuccess(data, accept){
  console.log('successful connection to socket.io');

  // The accept-callback still allows us to decide whether to
  // accept the connection or not.
  accept(null, true);

  // OR

  // If you use [email protected] the callback looks different
  accept();
}

It's unclear whether or not you should use accept(); or accept(null, true); for socket.io versions less than or greater than 1.0. The instructions only specify to use accept(); for any 1.X version, however it is unclear if accept(null, true); should be used for versions before or after 1.0. This is problematic, since there is currently a socket.io v4.X out.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant