You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
midiinstruments:
...
[24, "Acoustic Guitar (nylon)"],
[25, "Acoustic Guitar (steel)"],
[26, "Electric Guitar (jazz)"],
[27, "Electric Guitar (clean)"],
[28, "Electric Guitar (muted)"],
...
so, after calling getSoundfontInstrumentName() this names we got "acoustic_guitar_(nylon)" but it should be "acoustic_guitar_nylon", because file musyngkiteInstruments.ts include this name.
The text was updated successfully, but these errors were encountered:
Hi!
this method doesnt replace round brackets
private getSoundfontInstrumentName(midiName: string): string {
return midiName.toLowerCase().replace(/\s+/g, "_");
}
midiinstruments:
...
[24, "Acoustic Guitar (nylon)"],
[25, "Acoustic Guitar (steel)"],
[26, "Electric Guitar (jazz)"],
[27, "Electric Guitar (clean)"],
[28, "Electric Guitar (muted)"],
...
so, after calling getSoundfontInstrumentName() this names we got "acoustic_guitar_(nylon)" but it should be "acoustic_guitar_nylon", because file musyngkiteInstruments.ts include this name.
The text was updated successfully, but these errors were encountered: