Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select instrument per instrument not voice? #28

Open
djae88 opened this issue Jul 30, 2020 · 2 comments
Open

Select instrument per instrument not voice? #28

djae88 opened this issue Jul 30, 2020 · 2 comments

Comments

@djae88
Copy link

djae88 commented Jul 30, 2020

Hi, I'm not sure this title is right, haha... I'm bad at English

image

in this example above, first staff is for vocal and second, third staves are for piano part
and I don't think there are many people who need to change the piano part (second and the third) seperately.
because it was originally designated as one instrument (by writer)

So I think it's better to show select option per instrument, not voice

I came up with this idea, because of some writer's sheet gets more voices than staves in one instrument (for no reason),
and It doesn't look good.
image

I'm trying to do this myself but it's difficult for me
If you update this, it will be of great help

Thanks :)

@jimutt
Copy link
Owner

jimutt commented Aug 14, 2020

@djae88 Sorry for the late reply!
It's a good topic you're bringing up here. And I agree that in the example you posted it would really make sense to control playback per instrument and not per voice.

The reason to why I am currently not defaulting to that behavior (I actually tried that first) is because it can differ quite much how the instruments are specified in the Music XML. For example I had some coral pieces where piano was set as instrument for all for voices. Although it was set for a standard 4 voice SATB.

Which lead to the decision to make it per voice. But, I think a much a more sensible choice would be to default to selecting the playback instrument per "instrument". But offering individual control for all voices as an additional option.

The progress has been quite slow here lately, but I'd still like to address the previous issues you and some other persons have reported, as well as adjusting this. So I'll hopefully be able to look into it soon 🙂 PR's are also welcome

@djae88
Copy link
Author

djae88 commented Aug 17, 2020

Thank you for consideration, I'm looking forward to it!

@djae88 djae88 closed this as completed Aug 17, 2020
@djae88 djae88 reopened this Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants