Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeat support #4

Open
jimutt opened this issue Apr 29, 2020 · 5 comments
Open

Repeat support #4

jimutt opened this issue Apr 29, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@jimutt
Copy link
Owner

jimutt commented Apr 29, 2020

  • Handle barline repeats
  • Support toggling repeats on/off

Basic repeat handling would first need to be supported by the iterator/cursor in OSMD. Then it should be quite straight forward to just start using it here.

@jimutt jimutt added the enhancement New feature or request label Apr 29, 2020
@jimutt
Copy link
Owner Author

jimutt commented May 1, 2020

Experimenting some with this in a private osmd fork: https://twitter.com/jimutt/status/1256223916751798276?s=20)

@djae88
Copy link

djae88 commented Jun 15, 2020

Hi I'm so glad to see this repeat support function
because I've been waiting for this for a very long time.
I saw this work on Twitter
but not updated on this project yet
I want to try some of these repeat function
If you don't mind, can I get some code about this repeat function?

best regards

@jonatasgrosman
Copy link

Hi @jimutt , first of all, thanks for this excellent player that you've made... And, like @djae88 I'm looking forward to that feature. I'm working on a project right now that needs a feature like that. And now, we are thinking about fork your project to implement this by ourselves, but I wanna know if you have any plans to release this feature in the near future... Thanks again dude, for your great work, you've saved me a lot of work! :)

@jimutt
Copy link
Owner Author

jimutt commented Jul 12, 2020

@grosmanjs Thanks, I'm glad you like it! When it comes to repeat support the majority of work preferably needs to be done in the OSMD project, since the iterator belongs there. I did do some changes in my private OSMD branch (you can checkout my experimental changes here jimutt/opensheetmusicdisplay#1) to support barline repeats pretty well, but I think it's quite far off from being mergeable to the main OSMD project. Especially if the text based repeats are to be generically supported.

Although lately I've been involved in some discussions with the OSMD main contributors about helping out with the official audio player functionally which they've got funding for.

So what I'm saying is that my primary focus now will most likely be to help work towards the official audio player. And as such I'm afraid you can't rely on me prioritizing the repeat functionality right now. So if you're in a hurry it could be an idea to look into it yourself 🙂

@jonatasgrosman
Copy link

Thanks for your reply @jimutt ... no problem, we'll find a way here to get around this issue by ourselves for now, but we are looking forward to this OSMD official player, please help those guys to release this asap 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants