-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repeat support #4
Comments
Experimenting some with this in a private osmd fork: https://twitter.com/jimutt/status/1256223916751798276?s=20) |
Hi I'm so glad to see this repeat support function best regards |
Hi @jimutt , first of all, thanks for this excellent player that you've made... And, like @djae88 I'm looking forward to that feature. I'm working on a project right now that needs a feature like that. And now, we are thinking about fork your project to implement this by ourselves, but I wanna know if you have any plans to release this feature in the near future... Thanks again dude, for your great work, you've saved me a lot of work! :) |
@grosmanjs Thanks, I'm glad you like it! When it comes to repeat support the majority of work preferably needs to be done in the OSMD project, since the iterator belongs there. I did do some changes in my private OSMD branch (you can checkout my experimental changes here jimutt/opensheetmusicdisplay#1) to support barline repeats pretty well, but I think it's quite far off from being mergeable to the main OSMD project. Especially if the text based repeats are to be generically supported. Although lately I've been involved in some discussions with the OSMD main contributors about helping out with the official audio player functionally which they've got funding for. So what I'm saying is that my primary focus now will most likely be to help work towards the official audio player. And as such I'm afraid you can't rely on me prioritizing the repeat functionality right now. So if you're in a hurry it could be an idea to look into it yourself 🙂 |
Thanks for your reply @jimutt ... no problem, we'll find a way here to get around this issue by ourselves for now, but we are looking forward to this OSMD official player, please help those guys to release this asap 😄 |
Basic repeat handling would first need to be supported by the iterator/cursor in OSMD. Then it should be quite straight forward to just start using it here.
The text was updated successfully, but these errors were encountered: