Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base-mapped pages are not used for extracted annotations #530

Open
qqobb opened this issue May 10, 2021 · 0 comments · May be fixed by #531
Open

Base-mapped pages are not used for extracted annotations #530

qqobb opened this issue May 10, 2021 · 0 comments · May be fixed by #531

Comments

@qqobb
Copy link
Contributor

qqobb commented May 10, 2021

As reported here, ZotFile doesn't extract correct page numbers for Legal Case items, while this works fine for Journal Article items.

According to https://api.zotero.org/schema, the case item type uses the firstPage field, which is base-mapped to pages. The issue here occurs because ZotFile is currently not using base-mapped pages for extracted annotations.

I'll create a PR that adds parameters to the getField function such that the pages base field is used for extracted annotations.

BTW, I will refer ZotFile users to these instructions how to install the development version.
qqobb added a commit to qqobb/zotfile that referenced this issue May 10, 2021
@qqobb
Use base-mapped pages for extracted annotations
4aebd7f 
Fixes jlegewie#530.
@qqobb qqobb linked a pull request May 10, 2021 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use base-mapped pages for extracted annotations qqobb/zotfile
1 participant
@qqobb