Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XCode Instruments 16 breaks Deep Copy format import #481

Closed
akumansley opened this issue Sep 19, 2024 · 3 comments · Fixed by #484
Closed

XCode Instruments 16 breaks Deep Copy format import #481

akumansley opened this issue Sep 19, 2024 · 3 comments · Fixed by #484

Comments

@akumansley
Copy link

Here's a sample Deep Copy from Instruments 16, which seems to have slightly different spacing:

Weight	Self Weight	Symbol Names
2.18 s  100.0%	0 s	 node (98674)
1.98 s  90.8%	0 s	  start
1.98 s   0.0%	0 s	   node::Start(int, char**)
1.98 s   0.0%	0 s	    node::LoadSnapshotDataAndRun(node::SnapshotData const**, node::InitializationResult const*)
1.98 s   0.0%	0 s	     node::NodeMainInstance::Run()
@jlfwong
Copy link
Owner

jlfwong commented Sep 19, 2024

Hi! Thanks for the heads up. I'd accept a PR to resolve this while still maintaining functionality for past versions of Instruemnts. The relevant file to change is importFromInstrumentsDeepCopy

@MAUIoxo
Copy link

MAUIoxo commented Nov 16, 2024

Hi there,
unfortunately, I also have a broken .trace from use of XCode 16. When do you think it can go productive with this fix?

@jlfwong
Copy link
Owner

jlfwong commented Nov 17, 2024

@akumansley @robert3005 This is now merged and live on https://www.speedscope.app/

@MAUIoxo Unfortunately, I think your issue is slightly different an unlikely to be resolved. Instruments' file format has evolved significantly since I wrote the support for Instruments import and I never got around to doing the added reverse engineering work to figure out what's going on. See #196. It's possible using "deep copy" as a workaround will still allow you to accomplish what you need to though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants