Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change in reshape affecting old MAyflower project #3351

Open
cymplecy opened this issue May 9, 2024 · 1 comment
Open

Change in reshape affecting old MAyflower project #3351

cymplecy opened this issue May 9, 2024 · 1 comment

Comments

@cymplecy
Copy link
Contributor

cymplecy commented May 9, 2024

I loaded in my old Mayflower tracking project from a couple of years ago and noticed that my menus were distorted
in V8
image

in V9
image

using git bisect I worked out it was due to this commit which changed the reshape reporter
10b3166

The change that affect my project comes down to this difference in behaviour
in V8
showHazard script pic (2)

where I relied on the fact that nothing is produced if 1st parameter is 0

but in V9, it returns
showHazard script pic (1)

I can obviously work around this with an if but reporting it for you to decide if it's a bug or a new feature :)

@cymplecy
Copy link
Contributor Author

cymplecy commented May 9, 2024

The actual piece of code where I was relying on old behaviour

showHazard script pic (4)
If second width < main width, nothing used to be appended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant