Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOM list including "L" does not behave as expected #539

Open
kristofarkas opened this issue Oct 4, 2022 · 6 comments
Open

DOM list including "L" does not behave as expected #539

kristofarkas opened this issue Oct 4, 2022 · 6 comments

Comments

@kristofarkas
Copy link
Contributor

kristofarkas commented Oct 4, 2022

A cron expression for every 15th and last day of the month at 12:00 does not behave as expected and skips the last days when asked for next execution time.

Example cron schedule: 0 0 L,15 * *

While the cron expression is "valid" I wonder if this is in fact not supported.

@jmrozanec
Copy link
Owner

@kristofarkas, thank you for reporting this. May we ask you for a PR with a test reproducing the issue? Thanks! 😄

@jmrozanec jmrozanec added this to the next milestone Oct 4, 2022
kristofarkas added a commit to kristofarkas/cron-utils that referenced this issue Oct 4, 2022
@kristofarkas
Copy link
Contributor Author

@mccartney
Copy link
Contributor

(just a lurker, not part of the project, just trying to help)

"valid" I wonder if this is in fact not supported.

The README for this project says:

Non-standard characters L, W, LW, '?' and # are supported as well!

so I think the intent is for L to be supported.

@kristofarkas
Copy link
Contributor Author

When using the ‘L’ option, it is important not to specify lists, or ranges of values, as you’ll get confusing/unexpected results.

This quote is from the quarz cron tutorial here: http://www.quartz-scheduler.org/documentation/quartz-2.3.0/tutorials/crontrigger.html. Is L,15 a list? And if so does it fall under the this quote?

@kristofarkas
Copy link
Contributor Author

Any thoughts on this @jmrozanec? I could contribute a fix (if this is indeed a bug) with some help from you on where to look.

@jmrozanec
Copy link
Owner

@kristofarkas, if the expression is valid, it must be supported as defined in the specification. We will be glad to merge a PR with a valid fix 😄 Thanks!

jmrozanec added a commit that referenced this issue Nov 5, 2022
[BUG] Add failing test for issue #539
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants